New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve streams for Gulp 4 #108
Comments
I think I might run in the same issue here. I'm trying to make the reporter fail on warnings, in order to make the CI build fail. But unfortunately my custom reporter isn't able to make the pipe fail. |
@brendanfalkowski The plugin emits a @nirazul Perhaps you can use a different configuration for your CI that elevates severity of warnings? |
@olegskl — I'm not sure exactly how splitting the streams helps, but I'm just passing on the feedback from @phated to find a solution and document getting a nicer local dev experience for others to reference. Consider me just a loving user of these tools, but I don't have the same depth with JS streams as the creators. Something is handled differently because in my Gulp 3 build
In Gulp 4, the errors are reported but a success notifier also fires (right after the failing notifier).
I'm guessing this happens because the "lintCss" task is finishing, and that's what it's supposed to do when the linter runs and passes:
This could very well be my Gulpfile's patterns or my error formatter. Both of them changed between Gulp 3 and 4, but my new build is using fewer packages and more native Gulp/Node functions. I was hoping it was a simple config change, but the options I tried didn't help: |
@olegskl I would prefer to keep one single configuration as I do with |
I think there's an opportunity to make
gulp-stylelint
more Gulp-like by splitting linting and reporting into separate streams.I recently migrated my "frontend starter" repo from Gulp 3 to 4, and volunteered as the guinea pig for Gulp Office Hours where @phated helped diagnose some issues with error handling and notifications (for better dev experience).
I still have an issue with
gulp-stylelint
— this manifests as the linter always ending successfully, so the notifier always fires a success (in addition to any warning/error). There's a good discussion going on here, and it's important to me because Stylelint is the best maintained linter for CSS:gravitydepartment/frontend-starter#4
@olegskl — Do you have any ideas for this? Or would you be interested in participating in another Gulp Office Hours session to refactor?
The text was updated successfully, but these errors were encountered: