Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include Addition (Add) blending mode + Officially drop support for Node 8 #904

Merged
merged 4 commits into from Jun 29, 2020

Conversation

GlitchyPSIX
Copy link
Contributor

@GlitchyPSIX GlitchyPSIX commented Jun 26, 2020

What's Changing and Why

Addition mode is being... added to the list of compositing modes. Minor change (new feature), fulfills the old request from #724 because I also needed it)

What else might be affected

Nothing else in the core package should be affected.

Tasks

  • Add tests [Not necessary]
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label
📦 Published PR as canary version: 0.14.0-canary.904.976.0

✨ Test out this PR locally via:

npm install @jimp/cli@0.14.0-canary.904.976.0
npm install @jimp/core@0.14.0-canary.904.976.0
npm install @jimp/custom@0.14.0-canary.904.976.0
npm install jimp@0.14.0-canary.904.976.0
npm install @jimp/plugin-blit@0.14.0-canary.904.976.0
npm install @jimp/plugin-blur@0.14.0-canary.904.976.0
npm install @jimp/plugin-circle@0.14.0-canary.904.976.0
npm install @jimp/plugin-color@0.14.0-canary.904.976.0
npm install @jimp/plugin-contain@0.14.0-canary.904.976.0
npm install @jimp/plugin-cover@0.14.0-canary.904.976.0
npm install @jimp/plugin-crop@0.14.0-canary.904.976.0
npm install @jimp/plugin-displace@0.14.0-canary.904.976.0
npm install @jimp/plugin-dither@0.14.0-canary.904.976.0
npm install @jimp/plugin-fisheye@0.14.0-canary.904.976.0
npm install @jimp/plugin-flip@0.14.0-canary.904.976.0
npm install @jimp/plugin-gaussian@0.14.0-canary.904.976.0
npm install @jimp/plugin-invert@0.14.0-canary.904.976.0
npm install @jimp/plugin-mask@0.14.0-canary.904.976.0
npm install @jimp/plugin-normalize@0.14.0-canary.904.976.0
npm install @jimp/plugin-print@0.14.0-canary.904.976.0
npm install @jimp/plugin-resize@0.14.0-canary.904.976.0
npm install @jimp/plugin-rotate@0.14.0-canary.904.976.0
npm install @jimp/plugin-scale@0.14.0-canary.904.976.0
npm install @jimp/plugin-shadow@0.14.0-canary.904.976.0
npm install @jimp/plugin-threshold@0.14.0-canary.904.976.0
npm install @jimp/plugins@0.14.0-canary.904.976.0
npm install @jimp/test-utils@0.14.0-canary.904.976.0
npm install @jimp/bmp@0.14.0-canary.904.976.0
npm install @jimp/gif@0.14.0-canary.904.976.0
npm install @jimp/jpeg@0.14.0-canary.904.976.0
npm install @jimp/png@0.14.0-canary.904.976.0
npm install @jimp/tiff@0.14.0-canary.904.976.0
npm install @jimp/types@0.14.0-canary.904.976.0
npm install @jimp/utils@0.14.0-canary.904.976.0
# or 
yarn add @jimp/cli@0.14.0-canary.904.976.0
yarn add @jimp/core@0.14.0-canary.904.976.0
yarn add @jimp/custom@0.14.0-canary.904.976.0
yarn add jimp@0.14.0-canary.904.976.0
yarn add @jimp/plugin-blit@0.14.0-canary.904.976.0
yarn add @jimp/plugin-blur@0.14.0-canary.904.976.0
yarn add @jimp/plugin-circle@0.14.0-canary.904.976.0
yarn add @jimp/plugin-color@0.14.0-canary.904.976.0
yarn add @jimp/plugin-contain@0.14.0-canary.904.976.0
yarn add @jimp/plugin-cover@0.14.0-canary.904.976.0
yarn add @jimp/plugin-crop@0.14.0-canary.904.976.0
yarn add @jimp/plugin-displace@0.14.0-canary.904.976.0
yarn add @jimp/plugin-dither@0.14.0-canary.904.976.0
yarn add @jimp/plugin-fisheye@0.14.0-canary.904.976.0
yarn add @jimp/plugin-flip@0.14.0-canary.904.976.0
yarn add @jimp/plugin-gaussian@0.14.0-canary.904.976.0
yarn add @jimp/plugin-invert@0.14.0-canary.904.976.0
yarn add @jimp/plugin-mask@0.14.0-canary.904.976.0
yarn add @jimp/plugin-normalize@0.14.0-canary.904.976.0
yarn add @jimp/plugin-print@0.14.0-canary.904.976.0
yarn add @jimp/plugin-resize@0.14.0-canary.904.976.0
yarn add @jimp/plugin-rotate@0.14.0-canary.904.976.0
yarn add @jimp/plugin-scale@0.14.0-canary.904.976.0
yarn add @jimp/plugin-shadow@0.14.0-canary.904.976.0
yarn add @jimp/plugin-threshold@0.14.0-canary.904.976.0
yarn add @jimp/plugins@0.14.0-canary.904.976.0
yarn add @jimp/test-utils@0.14.0-canary.904.976.0
yarn add @jimp/bmp@0.14.0-canary.904.976.0
yarn add @jimp/gif@0.14.0-canary.904.976.0
yarn add @jimp/jpeg@0.14.0-canary.904.976.0
yarn add @jimp/png@0.14.0-canary.904.976.0
yarn add @jimp/tiff@0.14.0-canary.904.976.0
yarn add @jimp/types@0.14.0-canary.904.976.0
yarn add @jimp/utils@0.14.0-canary.904.976.0

@GlitchyPSIX GlitchyPSIX marked this pull request as ready for review June 26, 2020 02:56
@GlitchyPSIX
Copy link
Contributor Author

No clue why it's failing on node8. It says the GIF export reached a timeout but I don't think that's my fault as every other check passed...

Maybe this is what the commits meant by "browser version being broken"?

@hipstersmoothie
Copy link
Collaborator

You can drop the node 8 config. we can officially drop support with this PR

"access": "public"
}
}
"name": "@jimp/core",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes to this file please

Copy link
Collaborator

@hipstersmoothie hipstersmoothie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the package.json and this is good to merge

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Jun 29, 2020
@GlitchyPSIX
Copy link
Contributor Author

Just fix the package.json and this is good to merge

This good?
(First time contributing to another library, sorry if I mess up every now and then)

@hipstersmoothie hipstersmoothie changed the title include Addition (Add) blending mode include Addition (Add) blending mode + Officially drop support for Node 8 Jun 29, 2020
@hipstersmoothie
Copy link
Collaborator

@GlitchyPSIX Perfect!

No worries, not all repos have their releases automated in the same way jimp does (using https://github.com/intuit/auto)

@hipstersmoothie hipstersmoothie merged commit 37cc5c6 into jimp-dev:master Jun 29, 2020
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v0.14.0 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants