Remove 'browser' field from main jimp package's package.json. Fixes:#694 #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 PR was released in |
|
Can I see what error this pull request produces in CI? I would like to try and fix it. |
|
It was all good. published now |
|
Ah, alright. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
The
browsertag inpackages/jimp/package.jsonis being removed. It interferes with Browserify's dependency resolution, breaking it and ironically rendering Jimp unusable in Browserify. Meanwhile, building a single JavaScript file for manual inclusion in a webpage remains trivial, as is distributing it, using Browserify.What else might be affected
Nothing, which is why I made the decision to simply remove the disruptive field rather than replacing it with something else. Distributing the JavaScript file for clientside (e.g. HTML) inclusion of Jimp is done separately from
npm, because browsers (and other client-side JavaScript applications) don't usenpm, which is for server-side applications (i.e. Node.js). That, however, is a concern beyond that of this specific pull request.Tasks
jimp.d.ts