Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-swipeable-views-utils support for typescript #506

Open
gqmartins opened this issue Apr 17, 2019 · 3 comments · May be fixed by #609
Open

react-swipeable-views-utils support for typescript #506

gqmartins opened this issue Apr 17, 2019 · 3 comments · May be fixed by #609
Labels
needs testing This PR needs testing

Comments

@gqmartins
Copy link

gqmartins commented Apr 17, 2019 •
edited

Hello,

I was trying to import react-swipeable-views-utils in a typescript project, and just couldn't find it. Is there a typescript version for this package? I have found a typescript version for react-swipeable-views, but for utils I can't find one.

Thanks in advance!
@oliviertassinari
Copy link
Owner

@gqmartins It would be great to add the TypeScript definitions in this package!

@gqmartins
Copy link
Author

you think it would take a lot of time to do? what I'm trying to do is the same thing displayed in the circular demo. I don't know if that's possible only with the react-swipeable-views package

@oliviertassinari
Copy link
Owner

@gqmartins I focus on Material-UI, but we plan on providing a carousel for the library. I want to depend on react-swipeable-views to do such. We take TypeScript definitions very seriously on Material-UI side. We will need to do the same here. Ideally, I would move the definitions from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-swipeable-views in here and cover all the packages. But I won't have the time to do it before a few months.

@kodai3 kodai3 linked a pull request Jul 12, 2020 that will close this issue
Open
@caleb-harrelson caleb-harrelson added the needs testing This PR needs testing label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs testing This PR needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[type] Move type definitions from DefinitelyTyped kodai3/react-swipeable-views
3 participants
@oliviertassinari @gqmartins @caleb-harrelson