Skip to content
This repository has been archived by the owner on Nov 20, 2019. It is now read-only.

Asset list should include source maps #44

Open
rezonant opened this issue Sep 7, 2017 · 1 comment
Open

Asset list should include source maps #44

rezonant opened this issue Sep 7, 2017 · 1 comment
Labels
needmore Need more information

Comments

@rezonant
Copy link

rezonant commented Sep 7, 2017

Looks like the asset list provided by this plugin doesn't include generated source maps. I also noticed the manifest generated by https://github.com/arthurbergmz/webpack-pwa-manifest does not get included.

@rezonant rezonant changed the title Asset list doesn't include source maps Asset list should include source maps Sep 7, 2017
@woutervanvliet
Copy link
Collaborator

You can probably include sourceMaps by adding a transformOptions function, that defines what data ends up in your ServiceWorker code. But only if you promise you won't cache sourcemap files in a production build ;-)

Tbh, I'm not sure if it's good practice to cache the manifest - but it shouldn't be impossible. If the problem still exists, could you provide a minimal repo to reproduce the problem?

@woutervanvliet woutervanvliet added the needmore Need more information label Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needmore Need more information
Projects
None yet
Development

No branches or pull requests

2 participants