Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colons in hostname cause an error on Windows #4088

Open
jmorganca opened this issue May 1, 2024 · 2 comments · May be fixed by #4107
Open

Colons in hostname cause an error on Windows #4088

jmorganca opened this issue May 1, 2024 · 2 comments · May be fixed by #4107
Assignees
@bmizerany
Labels
bug Something isn't working windows

Comments

@jmorganca
Copy link
Member

What is the issue?

Including a colon in the hostname such as localhost:6000/my/model causes an error on windows:

$ ollama create -f ../models/Modelfile localhost:3000/library/tmp
transferring model data
reading model metadata
creating template layer
using already created layer sha256:4fed7364ee3e0c7cb4fe0880148bfdfcd1b630981efa0802a6b62ee52e7da97e
using already created layer sha256:fa8235e5b48faca34e3ca98cf4f694ef08bd216d28b58071a1f85b1d50cb814d
using already created layer sha256:d47ab88b61ba20ed39a1b205a7d5a8e201dcf09107e6b05f128778c32baa4a69
using already created layer sha256:e14c21df1d1c6baff291558d0da327e5aabe4d4e7dd97bc1bf173e535f2ab210
using already created layer sha256:cb4e88e025cabd86f873cd94972dc82cfd883336b2294882a5c28af996a4db92
writing manifest
Error: mkdir C:\Users\jmorg\.ollama\models\manifests\localhost:3000: The directory name is invalid.

OS

Windows

GPU

No response

CPU

No response

Ollama version

No response
@jmorganca jmorganca added bug Something isn't working windows labels May 1, 2024
@jmorganca jmorganca mentioned this issue May 1, 2024
Merged
@bmizerany
Copy link
Contributor

What should this resolve to in a filepath? I propose host%port/..

@jmorganca
Copy link
Member Author

That seems like a great choice

bmizerany added a commit that referenced this issue May 2, 2024
@bmizerany
types/model: make Name.Filepath substitute colons in host with ("%")
53241e1 
This makes the filepath legal on all supported platforms.

Fixes #4088
@bmizerany bmizerany linked a pull request May 2, 2024 that will close this issue
Open
bmizerany added a commit that referenced this issue May 2, 2024
@bmizerany
types/model: make Name.Filepath substitute colons in host with ("%")
cb3f445 
This makes the filepath legal on all supported platforms.

Fixes #4088
bmizerany added a commit that referenced this issue May 2, 2024
@bmizerany
types/model: make Name.Filepath substitute colons in host with ("%")
32a1246 
This makes the filepath legal on all supported platforms.

Fixes #4088
bmizerany added a commit that referenced this issue May 3, 2024
@bmizerany
types/model: make Name.Filepath substitute colons in host with ("%")
61b287c 
This makes the filepath legal on all supported platforms.

Fixes #4088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmizerany bmizerany

Labels
bug Something isn't working windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

types/model: make Name.Filepath substitute colons in host with ("%") ollama/ollama
2 participants
@bmizerany @jmorganca