Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Request: Page Range Search #40

Open
GeorgeWL opened this issue Dec 12, 2017 · 2 comments
Open

Feat Request: Page Range Search #40

GeorgeWL opened this issue Dec 12, 2017 · 2 comments

Comments

@GeorgeWL
Copy link

GeorgeWL commented Dec 12, 2017

The current method limits one to getting a page of 10 results at a time for each API call, so to get more than 10 results, one has to call each page one by one.

For example, to get 30 results, one would have to do:
http://www.omdbapi.com/?apikey=`key`&s=test&type=movie&page=1
http://www.omdbapi.com/?apikey=`key`&s=test&type=movie&page=2
http://www.omdbapi.com/?apikey=`key`&s=test&type=movie&page=3

@worr
Copy link

worr commented May 25, 2018

Or alternatively, it'd be great to be able to specify a number of results per page, as is request here: worr/node-imdb-api#60

@GeorgeWL
Copy link
Author

GeorgeWL commented May 25, 2018

That also makes sense yeah. Either/or really.

I think I'd prefer it to have a default size and to remove pages entirely actually. Pages as a concept feels like they're trying to preempt how people will use the API, which is never a wise choice to make.

Add a ResultsLength option to every api call and a default length of 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants