New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

special case objects with only string values #27

Open

codefromthecrypt opened this issue May 22, 2021 · 0 comments

Contributor

codefromthecrypt commented May 22, 2021

When unmarshalling, I think we can special-case when the json represented only includes string fields.

Instead of

func (j *Download) UnmarshalJSON(b []byte) error {
	var raw map[string]interface{}
	if err := json.Unmarshal(b, &raw); err != nil {
		return err
	}
	if v, ok := raw["architecture"]; !ok || v == nil {

this

func (j *Download) UnmarshalJSON(b []byte) error {
	var raw map[string]string
	if err := json.Unmarshal(b, &raw); err != nil {
		return err
	}
	if v, ok := raw["architecture"]; !ok || v == "" {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment