Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White background for One Dark Italic on latest build #318

Open
danwilliams opened this issue Oct 16, 2023 · 10 comments
Open

White background for One Dark Italic on latest build #318

danwilliams opened this issue Oct 16, 2023 · 10 comments

Comments

@danwilliams
Copy link

Describe the bug
After upgrading to RustRover 2023.3, and using the latest One Dark 5.9.0 (which is the one that brings 2023.3 compatibility), I have found that the One Dark Italic theme now has a white background with dark text. Meanwhile the One Dark Vivid Italic still works, so I've changed to that for now. Both of the non-italic themes still work fine.

Notably this is not the same as reported in this other, similar ticket: #313

This issue only started with the latest 2023.3 with 5.9.0, and cannot be resolved with the steps in that other ticket - they have no effect.

Environment
RustRover 2023.3 EAP
Build #RR-233.8264.22, built on October 10, 2023

Licensed to RustRover EAP user: Dan Williams
Expiration date: December 9, 2023

Runtime version: 17.0.8.1+7-b1063.1 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

@apmwebdev
Copy link

apmwebdev commented Oct 16, 2023

I'm also seeing this, but in IntelliJ. The issue seems to be that whatever version you have active when you upgrade the plugin gets the white background, while the others look normal. I initially had it on italic, which broke. I then tried uninstalling and reinstalling the plugin on vivid italic, and now both italic and vivid italic are broken.

@MrMuetze
Copy link

Solution is presented here: #313 (comment)

@T3kla
Copy link

T3kla commented Oct 16, 2023

Proposed solution didn't work for me. Also, I'm experiencing this in the non italic version. Changing to italic does work tho.

@MrMuetze
Copy link

MrMuetze commented Oct 16, 2023

For me it helped to switch the Editor Scheme to something else, click "apply" and then change it back to "One Dark Vivid". Maybe give that a try if you haven't yet. It should be independent from the used color scheme. Just changing it to something else and then back to the desired one should help.

@apmwebdev
Copy link

apmwebdev commented Oct 16, 2023

The solution in #313 doesn't work for me either. EDIT: Yes it does.

@ConnHowe
Copy link

ConnHowe commented Oct 16, 2023

Same as you, and then the solution in #313 worked for me.

@apmwebdev
Copy link

I got it working. Not sure what I was doing wrong before, but after trying the #313 solution a couple more times, it started working. Thanks @MrMuetze.

@xsjcTony
Copy link

#313 Works for me

@danwilliams
Copy link
Author

danwilliams commented Oct 17, 2023

@MrMuetze I mentioned #313 in my original description, as I found it, and tried it. However, it hasn't resolved the issue for me. I tried it again just now. No dice. (I.e. changing via the Editor -> Color Scheme -> Scheme box.)

@apmwebdev agreed - I had One Dark Italic active, and that broke, so now I'm on One Dark Italic Vivid. Exact same as you. Thankfully that one still works.

Edit: I removed the plugin entirely, and also removed my custom colours file, then reinstalled the plugin. It works again now. I'm not sure what was in my custom file of any importance, as it all looks okay now... So yeah, if anyone else has this issue and #313 doesn't fix it, maybe try removing the custom colours file. Dunno.

@HausE13
Copy link

HausE13 commented Feb 15, 2024

Had this problem after updating to version 5.10.0. Looks like Color Scheme in Editor settings is not set correctly.

Fixes mentioned in #313 still worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

7 participants