Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in URL query parameter not updating the image. #2180

Open
shamiul110107 opened this issue Dec 18, 2023 · 1 comment
Open

Change in URL query parameter not updating the image. #2180

shamiul110107 opened this issue Dec 18, 2023 · 1 comment

Comments

@shamiul110107
Copy link

shamiul110107 commented Dec 18, 2023

Issue Description

I have loaded the image from an image URL. It works fine when the image changes in the remote server. But the issue happens when I have query parameters in the new URL. In that case, the new image is not showing though I have changed it. I don't know if Kingfisher is discarding the query parameters. But If I re-run the app the new image is showing. Here is the URL format,
https://cdn.example.com/uploads/movie/3866/thumb_3866.jpg?v=202312061100

What

@onevcat
Copy link
Owner

onevcat commented Dec 18, 2023

I am not 100% sure your case, but by default, Kingfisher uses the whole URL string as the cache key.

So, it means:

https://cdn.example.com/uploads/movie/3866/thumb_3866.jpg?v=202312061100

https://cdn.example.com/uploads/movie/3866/thumb_3866.jpg?v=1234567

means two different images in Kingfisher.

I don't know if Kingfisher is discarding the query parameters. But If I re-run the app the new image is showing.

I would suggest you check if you actually changed your model and used that new URL to ask Kingfisher to set the image view again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants