Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/inherited documents #941

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0x6368
Copy link

@0x6368 0x6368 commented May 13, 2020

Fixes #940

@codecov-io
Copy link

codecov-io commented May 13, 2020

Codecov Report

Merging #941 into master will increase coverage by 1.09%.
The diff coverage is 91.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #941      +/-   ##
============================================
+ Coverage     83.13%   84.23%   +1.09%     
- Complexity      414      446      +32     
============================================
  Files            39       39              
  Lines          1364     1440      +76     
============================================
+ Hits           1134     1213      +79     
+ Misses          230      227       -3     
Impacted Files Coverage Δ Complexity Δ
Mapping/Converter.php 91.66% <85.00%> (-2.22%) 26.00 <12.00> (+6.00) ⬇️
Mapping/DocumentParser.php 85.71% <91.66%> (+0.59%) 77.00 <15.00> (+19.00)
Service/IndexService.php 70.83% <100.00%> (+6.24%) 67.00 <3.00> (+3.00)
Test/AbstractElasticsearchTestCase.php 94.59% <100.00%> (+1.73%) 20.00 <5.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe3801c...94db79c. Read the comment docs.

@0x6368 0x6368 force-pushed the feature/inherited-documents branch from 94db79c to f15bc5c Compare May 13, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documents of inherited classes cannot be converted to arrays
2 participants