Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

@clouds56 I personally completely agree its very bizarre behaviour, I got very tripped up on that (granted I shouldn't be spamming keys but when desparate 😆 ) till we had that command added to the docs. I think in the oni.sh file which is run on macOS whilst installing, it could possibly be added, dont want to speak for every mac user but I think it'd be a great default

A second option could be to add a fix for it to the command palette, like we have for add to Path, and pop a notification up about it?

Tbh I remember it as one of my main blockers when I started using oni, which led to me often switching back to the terminal.

The notification I think is a good middle ground but would be curious to know if any mac users would prefer that.

Also I think for new users or people like me who occasionally lapse and spam keys in frustration/desperation the discoverability of the doc command (which even if placed at the top of the wiki will still depend on users actually reading the docs 😆 ) or even the path command which tbh I personally didn't discover till a month ago It can be a bit of an ?unnecessary risk for user experience if they have to run an obscure macOS command just to get vim to work normally 😢.

Sorry for haven't read the docs as well. After installing oni from brew cask, I struggled with Google for hours and finally find it's a macOS only issue.

Agree with @CrossR
I think if not all the users from macOS like changing defaults, at least show some notification at first startup (just like what atom does, I didn't know cmd+shift+p to open command palette until it told me)

Another option for macOS could be to simulate repeat key when receiving press and hold in normal and visual mode, and keep it as is in insert mode. (I'm not sure if it is possible)

Could always flip it the other way @Akin909 and apply the fix by default and have the notification go "Hey we've done this, you can disable it here" (or possibly have a button to open the cmd + shift+ p menu with that pre-typed if we add buttons to the notifications).

That way we preserve the choice but apply it by default.
Regardless (I don't use macOS so I could be wrong here) it feels like we should have the ability for the user to undo it, even if I see no benefit of it.

Anybody know what would the equivalent command to disable the ApplePressAndHoldEnabled for Oni only?

defaults write com.sublimetext.3 ApplePressAndHoldEnabled -bool false

E.g. what should com.sublimetext.3 be replaced with?

EDIT - after digging around it looks like it would be com.extropy.oni

@CrossR - just to be clear - basic text editing is completely broken without ApplePressAndHoldEnabled disabled. I don't just mean that keys won't repeat - if you hold down 'a', it will show the character accent menu, but at the same time keep inputting lots of 'a's, then if you press ctrl+c, all of those other 'a's will disappear.

I think we should definitely run the following by default.

defaults write com.extropy.oni ApplePressAndHoldEnabled -bool false

For me the editor was unusable until I ran that command.

I'm happy to make a pull request if somebody can point me to the correct area of code. I've worked with Electron before but I can't find anywhere that any kind of initialization script runs.

I am running macOS and I do not have this problem with vimR nor with Atom (also Electron-based). I only have this problem with Oni.

Looks like we should be using https://github.com/electron/electron/blob/master/docs/api/system-preferences.md#systempreferencessetuserdefaultkey-type-value-macos to set the value?

For Oni the equivalent is:

defaults write com.extropy.oni ApplePressAndHoldEnabled -bool false

hello, solution by @benjie works for me on mac os, thanks! Maybe it would a good idea for Oni to set this setting on macs by default so newbies don't bounce off the software just because the keys don't repeat ;)

Also I could not figure out what the equivalent was to use with the development build?

To my knowledge @benjie it should be the same? The small amount of work with a dev build on mac worked with the same I think, or perhaps @Akin909 remembers if there are any differences.

I have that setting set (it works on Oni) but it didn't work for me on the development build. I probably did something wrong, but I wondered if the dev build using electron directly meant that instead of com.extropy.oni we should use something related to electron itself?

defaults write com.extropy.oni ApplePressAndHoldEnabled -bool false

I installed via brew cask and tried the solution above but it doesn't seem to have worked.

Have you fully quit Oni after doing it?

@benjie :face_palm: I thought I had because I had run :q and the window closed but I didn't realize that the app itself was still running. After fully quitting and re-loading, it works now. Thank you!