Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Diff for sectioned table views and collection views #1

Open
larryonoff opened this issue Nov 10, 2017 · 7 comments
Open

Diff for sectioned table views and collection views #1

larryonoff opened this issue Nov 10, 2017 · 7 comments

Comments

@larryonoff
Copy link

Current API only supports diffs of two arrays. But iOS table views and collection views often needs support for sections. It can be represented as array of arrays.

Is it possible to add support for diff of array of arrays?

@onmyway133
Copy link
Owner

@larryonoff Hi, it does not work (as of my implementation of Wagner Fischer and Heckel algorithms) for array of arrays yet. I just made some changes to calculate IndexPath for a specific section in this release https://github.com/onmyway133/DeepDiff/releases/tag/1.1.1 which partly solves the problem

@onmyway133
Copy link
Owner

@larryonoff Hi, I'm doing the diff for sections now to serve this https://github.com/hyperoslo/Upstream. Will keep you posted

@riteshhgupta
Copy link

Hey @onmyway133, thanks for writing DeepDiff :)
Is there an update on diffing sections without using Upstream? I'm looking forward to add it as a diffing engine in my table/collection manager, let me know!

@skyfe79
Copy link

skyfe79 commented Sep 2, 2018

@larryonoff @onmyway133 @riteshhgupta Hi, I'm working on ReactComponentKit. It uses DeepDiff to diff for UICollectionView or UITableView. Thanks, @onmyway133. Also, It uses Redux and Component concept like React. There is some example of ReactComponentKit. I want to it helps you. :)

Best Regards,

@onmyway133
Copy link
Owner

@riteshhgupta Hi, I'm quite busy atm so not sure if I can add support for section now
@skyfe79 Looks like a nice combo, I like it a lot. Just added it to my curation https://github.com/onmyway133/fantastic-ios-architecture. Also for layout, have you considered this https://github.com/onmyway133/Anchors 😉

@skyfe79
Copy link

skyfe79 commented Sep 3, 2018

@onmyway133 Really thanks for the listing! Anchors is awesome to me. I'll use it and considering remove SnapKit. Anchors is great! :)

@stami
Copy link

stami commented Oct 19, 2018

@riteshhgupta I found this issue having the same feature request, but ended up using https://github.com/tonyarnold/Differ instead. It has sectioned diffing out-of-the-box, I recommend checking it out.

yoavhacohen pushed a commit to PickAI/DeepDiff that referenced this issue Dec 10, 2020
Feature/section aware diff

* adding section update functionality

Approved-by: Yoav HaCohen
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants