Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Change<T> could use a .map(...) method. #34

Open
jrogccom opened this issue Mar 5, 2019 · 1 comment
Open

Change<T> could use a .map(...) method. #34

jrogccom opened this issue Mar 5, 2019 · 1 comment

Comments

@jrogccom
Copy link

jrogccom commented Mar 5, 2019

I made a PR to this end. It can be useful when looking at changes while hiding private implementation. See #33 .

@PhilipDukhov
Copy link

PhilipDukhov commented Jan 28, 2020

+1 to this
Could you apply this pull request? I can't even make it locally in my project cause Insert<T>, Delete<T>, Replace<T> and Move<T> don't have public initializers😌

Beside that reload<T: DiffAware>(changes: ..)doesn't need to require T to be DiffAware. Maybe I'm missing something, but we don't need to store items inside Insert<T>, Delete<T>, Replace<T> and Move<T>, as we only calculate indexes from those.

Why do I need it? I have a data model, that is : DiffAware, but my table wrapper object that configures the cells can't be made : DiffAware.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants