TrimRight is not designed to trim Suffix

See: https://cs.opensource.google/go/go/+/refs/tags/go1.18.2:src/strings/strings.go;l=894 > // To remove a suffix, use TrimSuffix instead.
onsi · May 23, 2022 · 71ebb74 · 71ebb74
1 parent ef336aa
commit 71ebb74
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/integration/profiling_test.go b/integration/profiling_test.go
@@ -54,7 +54,7 @@ func ParseProfile(binary string, path string) ProfileLines {
 		var cumStat float64
 		if strings.Contains(cumStatEntry, "MB") {
 			var err error
-			cumStat, err = strconv.ParseFloat(strings.TrimRight(cumStatEntry, "MB"), 64)
+			cumStat, err = strconv.ParseFloat(strings.TrimSuffix(cumStatEntry, "MB"), 64)
 			ExpectWithOffset(1, err).ShouldNot(HaveOccurred())
 		} else {
 			duration, err := time.ParseDuration(cumStatEntry)