Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: onsi/ginkgo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.16.0
Choose a base ref
...
head repository: onsi/ginkgo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.16.1
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Apr 7, 2021

  1. v1.16.1 

    Supress deprecation warning for --stream on windows.
Fixes #793
    @onsi
    onsi committed Apr 7, 2021

    Verified

    This commit was signed with the committer’s verified signature.
    alexanderniebuhr Alexander Niebuhr
    SSH Key Fingerprint: r0jp6ir+/6vEqRElbEyxhL7hD76Z/S7vqQqSlNioT7s
    Verified
    Learn about vigilant mode
    Copy the full SHA
    e4cff82 View commit details
Showing with 9 additions and 3 deletions.
  1. +5 −0 CHANGELOG.md
  2. +1 −1 config/config.go
  3. +2 −1 ginkgo/run_command.go
  4. +1 −1 types/deprecation_support.go
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 1.16.1

### Fixes
- Supress --stream deprecation warning on windows (#793)

## 1.16.0

### Features
2 changes: 1 addition & 1 deletion config/config.go
View file
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ import (
"fmt"
)

const VERSION = "1.16.0"
const VERSION = "1.16.1"

type GinkgoConfigType struct {
RandomSeed int64
3 changes: 2 additions & 1 deletion ginkgo/run_command.go
View file
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@ import (
"math/rand"
"os"
"regexp"
"runtime"
"strings"
"time"

@@ -56,7 +57,7 @@ func (r *SpecRunner) RunSpecs(args []string, additionalArgs []string) {

deprecationTracker := types.NewDeprecationTracker()

if r.commandFlags.ParallelStream {
if r.commandFlags.ParallelStream && (runtime.GOOS != "windows") {
deprecationTracker.TrackDeprecation(types.Deprecation{
Message: "--stream is deprecated and will be removed in Ginkgo 2.0",
DocLink: "removed--stream",
2 changes: 1 addition & 1 deletion types/deprecation_support.go
View file
Original file line number Diff line number Diff line change
@@ -81,7 +81,7 @@ func (d *DeprecationTracker) DeprecationsReport() string {
out += formatter.F("{{light-yellow}}============================================={{/}}\n")
out += formatter.F("Ginkgo 2.0 is under active development and will introduce (a small number of) breaking changes.\n")
out += formatter.F("To learn more, view the migration guide at {{cyan}}{{underline}}https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md{{/}}\n")
out += formatter.F("To comment, chime in at {{cyan}}{{underline}}https://github.com/onsi/ginkgo/issues/711{{/}}\n")
out += formatter.F("To comment, chime in at {{cyan}}{{underline}}https://github.com/onsi/ginkgo/issues/711{{/}}\n\n")

for deprecation, locations := range d.deprecations {
out += formatter.Fi(1, "{{yellow}}"+deprecation.Message+"{{/}}\n")