- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GinkgoLogr does not produce newlines #1170
Comments
erdnas
added a commit
to erdnas/ginkgo
that referenced
this issue
Mar 27, 2023
erdnas
added a commit
to erdnas/ginkgo
that referenced
this issue
Mar 27, 2023
erdnas
added a commit
to erdnas/ginkgo
that referenced
this issue
Mar 27, 2023
hey @Nuckal777 can you take a quick look at this. i know you implemented the logr stuff back in #1067 - is the newline being proposed here consistent with the logr spec? |
Good catch, we should a |
onsi
pushed a commit
that referenced
this issue
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Outputs:
I would expect it to have a newline after each log call, for readability.
If we add a newline to the printf here (or change it to println), we get newlines as desired.
ginkgo/internal/writer.go
Lines 136 to 140 in 9b5078f
The text was updated successfully, but these errors were encountered: