Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core_dsl: disable Getwd() with environment variable #1357

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

kevinburke
Copy link
Contributor

os.Getwd() calls os.Getenv("PWD"), which can change from run to run if you are using a test suite runner like e.g. Buildkite. Because test caching relies on environment variables being the same from run to run, this facile change breaks test caching.

Fixes #1355.

os.Getwd() calls os.Getenv("PWD"), which can change from run to run if
you are using a test suite runner like e.g. Buildkite. Because test
caching relies on environment variables being the same from run to
run, this facile change breaks test caching.

Fixes onsi#1355.
@onsi onsi merged commit cd418b7 into onsi:master Feb 12, 2024
6 checks passed
@onsi
Copy link
Owner

onsi commented Feb 12, 2024

sorry for the delay - thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getwd() breaks test caching on build runners like Buildkite
2 participants