Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] dump specSummary with dry-run in v2 #956

Closed
chendave opened this issue Mar 31, 2022 · 1 comment
Closed

[Question] dump specSummary with dry-run in v2 #956

chendave opened this issue Mar 31, 2022 · 1 comment

Comments

@chendave
Copy link

chendave commented Mar 31, 2022

I am trying to migrate ginkgo from v1 to v2, there were a custom report defined to dump the specSummary with dryRun mode, this is workable in the v1, and it was implemented in SpecDidComplete.

func (reporter *DetailsReporter) SpecDidComplete(specSummary *types.SpecSummary) {
     // dump the spec summary here.
}

The migration guide here: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#migration-strategy-2 suggests to add a ReportAfterSuite node and process the types.Report in v2 to replace custom report. I tried and found that if it's dry-run mode in v2 neither ReportAfterSuite("", func(report Report) nor ReportAfterEach(func(report SpecReport) would got called, so what's the best practice in v2 for me to dump the test spec with dry-run mode?

thanks a lot for any input!

@onsi
Copy link
Owner

onsi commented Mar 31, 2022

hey there - this is similar to #935 - i'm going to be adding support for this in v2 soon

@onsi onsi closed this as completed in aae4480 Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants