Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Output plugin :after-task-stop lifecycle fn doesn't receive :onyx.core/scheduler-event #885

Open
thenonameguy opened this issue Feb 5, 2019 · 1 comment

Comments

@thenonameguy
Copy link
Contributor

thenonameguy commented Feb 5, 2019

There is no way currently for an output plugin to determine whether it was killed or completed.
Expected because of:
https://github.com/onyx-platform/onyx/blob/0.14.x/src/onyx/information_model.cljc#L829

@thenonameguy
Copy link
Contributor Author

thenonameguy commented Feb 6, 2019

For now I'm using:

(defn after-task-stop [{:keys [onyx.core/job-id onyx.core/replica-atom] :as event} lifecycle]
  (when (contains? (some-> replica-atom
                           deref
                           :completed-jobs
                           set)
                   job-id)
    ...)
  {})

to check for completions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant