Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component type comparison fails in dev mode #52

Closed
sarathms opened this issue May 3, 2019 · 0 comments · Fixed by #54
Closed

Component type comparison fails in dev mode #52

sarathms opened this issue May 3, 2019 · 0 comments · Fixed by #54

Comments

@sarathms
Copy link
Contributor

sarathms commented May 3, 2019

This particularly affects the <RadioGroup> component which looks for <RadioButton> type elements in this.props.children. This comparison fails when hot-module-replacement (HMR) is enabled in NODE_ENV=development. The issue and possible work-arounds are discussed here.

This might not be a problem in newer next.js versions which use newer react-hot-loader as dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix radio button dev mode ooni/design-system
1 participant
@sarathms