Use an ES5 compatible Regexp to assert legal characters #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. Can you please add back node 4 and 5 tests by reverting this: 15d4f1a |
|
Perfect. Thank you. 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were very happy about the fix for #147, because we also have users using emoji. But some of them still uses IE11 in their companies. IE11 stops the JavaScript parsing on the unknown
uRegex flag.This PR restores ES5 compatibility by replacing the legible ES6 Regexp with a more complex one generated using https://github.com/mathiasbynens/regenerate