You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Discovered in Definitely Typed: the plist typings depend on xmlbuilder. However, any Typescript code (or checked Javascript code) that depends on xmlbuilder will now have these errors. I'd recommend adding a call to tsc typings/index.d.ts to the CI run somewhere.
The import syntax for 'stream' should be import { Writable } from 'stream';.
abstract class XMLCharacterData seems to be referred to as CharacterData in the rest of the file.
XMLDocType incorrectly extends XMLNode — you can't return a subtype in an override, and many methods do this.
(1) and (2) have easy, obvious fixes. (3) I'm not so sure about -- probably XMLNode just needs to return this. Either way, I'll have a PR up shortly.
The text was updated successfully, but these errors were encountered:
Discovered in Definitely Typed: the
plist
typings depend on xmlbuilder. However, any Typescript code (or checked Javascript code) that depends on xmlbuilder will now have these errors. I'd recommend adding a call totsc typings/index.d.ts
to the CI run somewhere.'stream'
should beimport { Writable } from 'stream';
.abstract class XMLCharacterData
seems to be referred to asCharacterData
in the rest of the file.XMLDocType
incorrectly extendsXMLNode
— you can't return a subtype in an override, and many methods do this.(1) and (2) have easy, obvious fixes. (3) I'm not so sure about -- probably
XMLNode
just needs to returnthis
. Either way, I'll have a PR up shortly.The text was updated successfully, but these errors were encountered: