Add command-{name|index} and !command-{name|index} condition to --success

[gustavohenke]

Implements 2 (or 4?) new possible conditions for --success flag:

• command-{name|index}: command with the specified name or index must exit with 0;
• !command-{name|index}: all but the command with the specified name or index must exit with 0.

I think that it expanding the use of ! to !first and !last could come next, but for now that's an advanced enough solution!

Closes #280.
Related: #281

[coveralls]

Coverage increased (+0.07%) to 97.879% when pulling 7e0c855 on success-v2 into c5231ea on master.

[paescuj]

Hey @gustavohenke, the implementation looks good!

Basically, I like the solution with the command-{name|index} pattern. Just two thoughts from my side:

• The command name is not unique (while the index is), there can be multiple commands with the same name. It is important to understand that in this case, the command that has finished first (!) will be considered. Should we add a note for this?
• It can happen that the command with the specified name or index does not exist.
  In the case of !command- concurrently exits with code 0, in the case of command- concurrently exits with code 1. Should we cover this in a test case? Should we also add a note for this?

[gustavohenke]

there can be multiple commands with the same name

Addressed that. Now all commands with the same name must meet the same condition.
I've also amended --success help to use the plural.

Noteworthy: input handling also accepts a target command name, but it's also only sending it to the first matching command...

It can happen that the command with the specified name or index does not exist.
In the case of !command- concurrently exits with code 0, in the case of command- concurrently exits with code 1.
Should we cover this in a test case? Should we also add a note for this?

Covered it in tests -- might be fine to get away without more docs... I'd love to be able to write more about each flag, but --help already is pretty long 😞

[paescuj]

Suggested change

	* - `command-{name|index}`: only the command with the specified name or index.
	* - `!command-{name|index}`: all commands but the one with the specified name or index.
	* - `command-{name|index}`: only the commands with the specified name or index.
	* - `!command-{name|index}`: all commands but the ones with the specified name or index.

[paescuj]

Great work, LGTM!

Addressed that. Now all commands with the same name must meet the same condition.
I've also amended --success help to use the plural.

Nice, that makes very much sense 👍

Noteworthy: input handling also accepts a target command name, but it's also only sending it to the first matching command...

Okay, might be something to address in the future...

Covered it in tests -- might be fine to get away without more docs... I'd love to be able to write more about each flag, but --help already is pretty long 😞

Fine for me, I think it's a rare case anyway 👍

Yeah, it would be handy to have a different place to to document such details!