Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript not able to resolve types when set to Node16 #330

Merged
merged 1 commit into from Jun 14, 2022
Merged

Fix TypeScript not able to resolve types when set to Node16 #330

merged 1 commit into from Jun 14, 2022

Conversation

Baune8D
Copy link
Contributor

@Baune8D Baune8D commented Jun 14, 2022

Fix for this error when using TypeScript 4.7 set to Node16 module resolution.

image

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.903% when pulling 38a722f on Baune8D:fix-ts-ecma-resolving into eae1d8d on open-cli-tools:main.

Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great spot, thanks!

@gustavohenke gustavohenke merged commit 78559b7 into open-cli-tools:main Jun 14, 2022
@gustavohenke
Copy link
Member

Published as v7.2.2 ✅

@paescuj paescuj added the bug label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants