Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified flagd feature flag configuration #80

Open
toddbaert opened this issue Feb 15, 2023 · 1 comment
Open

Simplified flagd feature flag configuration #80

toddbaert opened this issue Feb 15, 2023 · 1 comment
Assignees

Comments

@toddbaert
Copy link
Member

toddbaert commented Feb 15, 2023

The current flagd flag configuration schema lacks some reasonable defaults that can easily be derived assumed:

  • Boolean flags don't really need variants explicitly defined - they essentially should always be true/false. We can make these variants "implied".
  • Flags states are generally ENABLED. We should implicitly assume they are ENABLED if the state is not defined.

Things that need to be done to accomplish this:

  • Relax JSON schema to support this.
  • Leverage relaxed schema in flagd and make required updates to state management to support this
  • Leverage relaxed schema in OFO
@beeme1mr
Copy link
Member

We'll need to update the schema store and the default variants should only be "true" or "false" when the variant property is omitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
3 participants