Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't spawn a goroutine #24

Open
edoakes opened this issue Nov 17, 2017 · 0 comments
Open

Don't spawn a goroutine #24

edoakes opened this issue Nov 17, 2017 · 0 comments
Assignees

Comments

@edoakes
Copy link
Member

edoakes commented Nov 17, 2017

In the multiple places that we used a named pipe for "ready" signals, we are spawning a goroutine to listen on it as the worker goroutine waits. We should just do the listen in the worker thread instead. Additionally, this code should be reused from a common place rather than being copy-pasted to the different locations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants