Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump-up(docker): update parser to the latest to be able to parse all keywords #805

Merged
merged 2 commits into from Apr 2, 2023
Merged

bump-up(docker): update parser to the latest to be able to parse all keywords #805

merged 2 commits into from Apr 2, 2023

Conversation

boranx
Copy link
Member

@boranx boranx commented Mar 28, 2023 •
edited

Fix: #802

Tests:

make build # on this branch
cat <<EOF | ./conftest parse --parser dockerfile - 
# syntax=docker/dockerfile:1.4
FROM alpine
COPY --link /foo /bar
EOF

@boranx boranx force-pushed the dockerfile-parser-bump-up branch 2 times, most recently from 2ec421e to 9f6c36d Compare March 28, 2023 09:31
@boranx
fix(docker): update parser to the latest to be able to parse all keyw…
83fc8b5 
…ords

Signed-off-by: boranx <boran.seref@gmail.com>
@boranx
fix: linting issues, failing unit test for spdx parser
b31f25b 
Signed-off-by: boranx <boran.seref@gmail.com>
@boranx boranx force-pushed the dockerfile-parser-bump-up branch from ecb2f92 to b31f25b Compare April 2, 2023 13:02
@boranx
Copy link
Member Author

boranx commented Apr 2, 2023

now the test is added as an acceptance test too. I'll merge this based on the comments confirming the fix worked

@boranx boranx merged commit 2a7c88e into open-policy-agent:master Apr 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support newer docker language syntax and features
1 participant
@boranx