Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the definition of active species/complexes? #524

Open
connorcoley opened this issue Dec 10, 2020 · 2 comments
Open

Support the definition of active species/complexes? #524

connorcoley opened this issue Dec 10, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@connorcoley
Copy link
Collaborator

connorcoley commented Dec 10, 2020

It is not uncommon for multiple inputs/components to result in the formation of an active catalyst complex in a reaction. It could be useful to allow users to specify what this complex is (e.g., by MolFile) and any associated computed compound features. This could be useful for machine learning on catalyst/ligand structures down the road without having to infer what the active species is based on multiple inputs.

It is not clear where these additional fields should go.

@connorcoley connorcoley added the enhancement New feature or request label Dec 10, 2020
@skearnes
Copy link
Collaborator

Has this been resolved?

@connorcoley
Copy link
Collaborator Author

It has not been resolved, no.

This is information that doesn't make sense to define at the input-level, since an active complex can be formed from multiple inputs. Defining active complexes / intermediate Compounds is one use for a reaction-level annotation. Another could be an estimate of a derived kinetic rate constant or energetic barrier, which would need some generic Data field.

These are thematically different from what is currently in the ReactionNotes message, but right now that's my top choice. I don't know if we'd want to add a catch-all for other reaction-related annotations there or add structured fields, e.g., repeated Compound intermediates or repeated Compound active_species

I think this is a low/medium-priority task that will require more thought

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants