feat: add @asirialwis as a contributor #320
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @asirialwis,
Thank you for your contribution! ✨
There are a few things here:
- Please create an issue as mention in our course to accompany this PR as it's the best practice in open source.
- You have a failed check that you need to address.
- I see that you haven't completed your PR template and you've deleted a section here. That said, please put back the section and fill it in (you can look at previous PRs to see what you've removed) and complete your PR template so we can understand the changes you made and the background of this PR.
You can read this blog post to learn the importance of templates and how to fill in a PR template.
We're only reviewing this PR once we get all the information needed.
Please let us know once you've completed the template or if you have any question.
Thank you. 🙂
asirialwis
changed the title
|
Hey @asirialwis, We have merged a PR before yours. Please resolve the conflicts before we can review your PR. Do let us know if you need any help. Thanks. 😊 |
|
I have solved the merge conflicts. |
There was a problem hiding this comment.
Hey there,
I highly recommend you read and follow the instructions to resolve merge conflicts in this repo.
From what I see here, you haven't run the command to generate your profile on README. And I think once you run it, it will throw an error. But don't get discouraged and just follow the instructions. 🙂
Let me know if you have any questions or need any help. ✨️
There was a problem hiding this comment.
Hi @asirialwis,
We've helped you resolve the merge conflicts in your PR. ✨
NOTE: For your future reference, please read and follow any instructions carefully. You can see the commit history in this PR to understand the changes that I made to resolve the conflicts.
If you haven't, you can join our community Discord. 😊
Also, check out our pizza-verse repo if you want to contribute further! 🍕
Description
This PR add @asirialwis as a contributor.
What type of PR is this? (check all applicable)
Related Issues
Closes #322
Contributors Checklist
I've read through the Getting Started section.
Have you run
npm run contributors:generateto generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?