Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Feature: add clickable link to the goals repo on the first-time setup #948

Closed
0-vortex opened this issue Apr 29, 2021 · 6 comments
Closed
Labels
🛑 blocked blocked by another issue. 🍕 enhancement 💡 feature A label to note if work is a feature question

Comments

@0-vortex
Copy link
Contributor

0-vortex commented Apr 29, 2021

Is your feature request related to a problem? Please describe.

After installing the Open Sauced GitHub application and creating the "open-sauced-goals" repository a link to it could be clickable before granting rights to the app.

Additional context can help what is happening after clicking the install button.

Describe the solution you'd like

Add an anchor to open the GitHub repository in a new tab.

Add some additional description instead or before redirecting to the goals repository.

Describe alternatives you've considered

Additional context

https://clips.twitch.tv/TenaciousKitschyDonkeyOSkomodo-SaSLo_p5485mkNTm

https://clips.twitch.tv/HealthyHealthyNewtPunchTrees-AivvMBrYgJPH3U7W

@mtfoley
Copy link
Contributor

mtfoley commented May 25, 2021

.take

@mtfoley
Copy link
Contributor

mtfoley commented May 25, 2021

I think I can do a PR that half-solves what's in the clips that @0-vortex linked up. The redirect is probably something @bdougie would need to do, if anyone. I don't know exactly how the open-sauced GitHub app is setup, but it looks like it's been configured through OneGraph because below the install button it says the user will be redirected to http://serve.onegraph.com/oauth/github/receive which I'm assuming is the callback URL. It seems to me there's a way of passing state (like user.login) along thru the OAuth flow, but I don't know if OneGraph could be configured to change the callback URL based on that state.

@mtfoley mtfoley removed their assignment May 27, 2021
@mtfoley
Copy link
Contributor

mtfoley commented May 27, 2021

I unassigned myself since the remainder of this issue (the redirect) would deal with configuration of the open-sauced GitHub app (which would be @bdougie).

@mtfoley
Copy link
Contributor

mtfoley commented Jun 29, 2021

@bdougie I changed a couple of labels, but tbh I don't know what label to apply when it's really just you that can wrap it up - the remainder deals with configuration of the open-sauced GitHub app for callback URLs, etc.

@bdougie
Copy link
Member

bdougie commented Sep 10, 2021

This can actually be done with the GitHub App. Blocked by octokit/app.js#269. Perhaps I can take a crack at contributing to that.

@bdougie bdougie added the 🛑 blocked blocked by another issue. label Sep 10, 2021
@bdougie bdougie self-assigned this Sep 10, 2021
@bdougie bdougie removed their assignment Dec 23, 2021
@0-vortex
Copy link
Contributor Author

Moving away from taking notes and into insights, the new onboarding process would overhaul this and just need down-streaming 🍕

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛑 blocked blocked by another issue. 🍕 enhancement 💡 feature A label to note if work is a feature question
Projects
None yet
Development

No branches or pull requests

3 participants