Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to remove note from inherited attribute #299

Closed
lmolkova opened this issue Mar 14, 2024 · 1 comment
Closed

Allow to remove note from inherited attribute #299

lmolkova opened this issue Mar 14, 2024 · 1 comment
Labels
bug Something isn't working semconv/md Related specifically to the markdown output of the semantic convention generator semconv Related to the semantic convention generator.

Comments

@lmolkova
Copy link
Contributor

I want to be able to remove the parent note when referencing an attribute. E.g. I have

- id: messaging.stuff
  attributes:
    - id: foo
      brief: some attribute
      note: here's a common attribute definition and individual messaging systems should put things like bar and baz here.

then I want to reference the attribute, but I don't need the note - note provided guidance for messaging extensions, I don't need it inside specific system definition.

- id: messaging.kafka    
  attributes:
    - ref: messaging.foo
      brief: kafka-specific precise and accurate brief
      note: # nothing here, brief provided all the details.

this fails with AttributeError: 'NoneType' object has no attribute 'strip'

@lmolkova lmolkova added bug Something isn't working semconv Related to the semantic convention generator. semconv/md Related specifically to the markdown output of the semantic convention generator labels Mar 14, 2024
@lmolkova
Copy link
Contributor Author

works in weaver - https://github.com/open-telemetry/semantic-conventions/pull/1092/files, so closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semconv/md Related specifically to the markdown output of the semantic convention generator semconv Related to the semantic convention generator.
Projects
Archived in project
Development

No branches or pull requests

1 participant