Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render note on referenced attributes by default #305

Closed
lmolkova opened this issue Mar 21, 2024 · 1 comment
Closed

Render note on referenced attributes by default #305

lmolkova opened this issue Mar 21, 2024 · 1 comment
Labels
bug Something isn't working semconv/md Related specifically to the markdown output of the semantic convention generator semconv Related to the semantic convention generator.

Comments

@lmolkova
Copy link
Contributor

Currently note is only rendered when attribute is defined in the corresponding group (being rendered) or if (full) mode is used.

It results in:

It complicates things and I see no good reason to not render note on referenced attributes.

@lmolkova lmolkova added bug Something isn't working semconv Related to the semantic convention generator. semconv/md Related specifically to the markdown output of the semantic convention generator labels Mar 21, 2024
@lmolkova
Copy link
Contributor Author

fixed in weaver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semconv/md Related specifically to the markdown output of the semantic convention generator semconv Related to the semantic convention generator.
Projects
None yet
Development

No branches or pull requests

1 participant