Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/signalfxexporter] Map the user agent string to the otel distribution #16841

Closed
atoulme opened this issue Dec 10, 2022 · 6 comments · Fixed by #27612
Closed

[exporter/signalfxexporter] Map the user agent string to the otel distribution #16841

atoulme opened this issue Dec 10, 2022 · 6 comments · Fixed by #27612
Labels
enhancement New feature or request exporter/signalfx help wanted Extra attention is needed priority:p3 Lowest

Comments

@atoulme
Copy link
Contributor

atoulme commented Dec 10, 2022 •
edited

Component(s)

exporter/signalfxexporter

Is your feature request related to a problem? Please describe.

The current SignalFx exporter maps to a static user agent string "OpenTelemetry-Collector SignalFx Exporter/v0.0.1"

Describe the solution you'd like

Allow the build info passed in from the host to populate the user agent string.

See #16837 (comment) for discussion.

Describe alternatives you've considered

No response

Additional context

No response
@atoulme atoulme added enhancement New feature or request needs triage New item requiring triage labels Dec 10, 2022
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme mentioned this issue Dec 10, 2022
Merged
@atoulme atoulme added exporter/signalfx priority:p3 Lowest and removed needs triage New item requiring triage labels Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Pinging code owners for exporter/signalfx: @pmcollins @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 10, 2023
@dmitryax dmitryax removed the Stale label Apr 10, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 12, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2023
@dmitryax dmitryax reopened this Aug 11, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 11, 2023
@atoulme atoulme added help wanted Extra attention is needed and removed Stale labels Oct 11, 2023
@atoulme atoulme mentioned this issue Oct 11, 2023
Merged
dmitryax pushed a commit that referenced this issue Oct 16, 2023
@atoulme
[exporter/signalfx] expose build version in user agent string (#27612)
4a1d7c8 
**Description:**
The current SignalFx exporter maps to a static user agent string
"OpenTelemetry-Collector SignalFx Exporter/v0.0.1".

This PR changes the version to match the build info version.

**Link to tracking Issue:**
Fixes #16841
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this issue Oct 18, 2023
@atoulme @JaredTan95
[exporter/signalfx] expose build version in user agent string (open-t…
edd5d3a 
…elemetry#27612)

**Description:**
The current SignalFx exporter maps to a static user agent string
"OpenTelemetry-Collector SignalFx Exporter/v0.0.1".

This PR changes the version to match the build info version.

**Link to tracking Issue:**
Fixes open-telemetry#16841
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@atoulme @jmsnll
[exporter/signalfx] expose build version in user agent string (open-t…
9c030f3 
…elemetry#27612)

**Description:**
The current SignalFx exporter maps to a static user agent string
"OpenTelemetry-Collector SignalFx Exporter/v0.0.1".

This PR changes the version to match the build info version.

**Link to tracking Issue:**
Fixes open-telemetry#16841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request exporter/signalfx help wanted Extra attention is needed priority:p3 Lowest
Projects
None yet
Milestone
No milestone
2 participants
@atoulme @dmitryax