[processor/redactionprocessor] fix mask when multiple patterns exist #27646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArchangelSDY
requested review from
dmitryax,
mx-psi,
TylerHelmuth and
a team
as code owners
ArchangelSDY
force-pushed
the
redact-multi
branch
2 times, most recently
from
a25daf8
to
978495d
Compare
|
@songy23 Added. |
ArchangelSDY
force-pushed
the
redact-multi
branch
2 times, most recently
from
65da1a6
to
455fe92
Compare
mx-psi
approved these changes
Oct 13, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
…pen-telemetry#27646) **Description:** Fix mask when multiple patterns exist With following input: ``` attr: <secret1> <secret2> ``` and config: ``` redaction: blocked_values: - '<secret1>' - '<secret2>' ``` Output before fix: ``` attr: <secret1> **** ``` Output after fix: ``` attr: **** **** ``` **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…pen-telemetry#27646) **Description:** Fix mask when multiple patterns exist With following input: ``` attr: <secret1> <secret2> ``` and config: ``` redaction: blocked_values: - '<secret1>' - '<secret2>' ``` Output before fix: ``` attr: <secret1> **** ``` Output after fix: ``` attr: **** **** ``` **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix mask when multiple patterns exist
With following input:
and config:
Output before fix:
Output after fix:
Link to tracking Issue:
Testing:
Documentation: