[pkg/translator/azure] Decode "incorrect" JSON without failing completely #28650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n though it does not meet specifications. Also allow the durationMs field to use a quoted or unquoted integer.
atoulme
approved these changes
Oct 26, 2023
MovieStoreGuy
approved these changes
Oct 27, 2023
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…tely (open-telemetry#28650) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> When decoding from Azure Resource Log format to OTel if a numeric field is represented without quotes the data will not be decoded and will fail silently. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#28648 **Testing:** <Describe what testing was performed and which tests were added.> Invalid data captured from Azure Diagnostic Setting and used to create a unit test. Then data was reprocessed with the Event Hubs Receiver. **Documentation:** <Describe the documentation added.> None required as this was a bug within the code.
6 tasks
cparkins
deleted the
bugfix/pkg/translator/azure/allow-bad-numeric-values
branch
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…tely (open-telemetry#28650) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> When decoding from Azure Resource Log format to OTel if a numeric field is represented without quotes the data will not be decoded and will fail silently. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#28648 **Testing:** <Describe what testing was performed and which tests were added.> Invalid data captured from Azure Diagnostic Setting and used to create a unit test. Then data was reprocessed with the Event Hubs Receiver. **Documentation:** <Describe the documentation added.> None required as this was a bug within the code.
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…tely (open-telemetry#28650) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> When decoding from Azure Resource Log format to OTel if a numeric field is represented without quotes the data will not be decoded and will fail silently. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#28648 **Testing:** <Describe what testing was performed and which tests were added.> Invalid data captured from Azure Diagnostic Setting and used to create a unit test. Then data was reprocessed with the Event Hubs Receiver. **Documentation:** <Describe the documentation added.> None required as this was a bug within the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When decoding from Azure Resource Log format to OTel if a numeric field is represented without quotes the data will not be decoded and will fail silently.
Link to tracking Issue:
#28648
Testing:
Invalid data captured from Azure Diagnostic Setting and used to create a unit test. Then data was reprocessed with the Event Hubs Receiver.
Documentation:
None required as this was a bug within the code.