Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix][apachesparkreceiver] Correct inaccurate metric units #29104

Merged
merged 6 commits into from Nov 14, 2023

Conversation

mrsillydog
Copy link
Contributor

@mrsillydog mrsillydog commented Nov 10, 2023

Description: Replacing inaccurate units for the spark.job.stage.active and spark.job.stage.result metrics for the Apache Spark receiver.

Link to tracking Issue: 29104

Testing: N/A

Documentation: Documentation for the metadata.yaml file was updated accordingly.

@mrsillydog
Copy link
Contributor Author

Lint failure unrelated (fixed by #29101), signalfx exporter test failure is also unrelated (see #29099)

@mrsillydog mrsillydog marked this pull request as ready for review November 10, 2023 20:31
@mrsillydog mrsillydog requested review from djaglowski and a team as code owners November 10, 2023 20:31
Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@mrsillydog
Copy link
Contributor Author

Failing integration tests unrelated

@djaglowski djaglowski merged commit bf6edaf into open-telemetry:main Nov 14, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 14, 2023
@mrsillydog mrsillydog deleted the bugfix/spark-metric-units branch November 14, 2023 18:00
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…elemetry#29104)

**Description:** Replacing inaccurate units for the
spark.job.stage.active and spark.job.stage.result metrics for the Apache
Spark receiver.


**Link to tracking Issue:**
[29104](open-telemetry#29104)

**Testing:** N/A

**Documentation:** Documentation for the metadata.yaml file was updated
accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants