-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] Add schema_url field to contexts #31444
base: main
Are you sure you want to change the base?
[pkg/ottl] Add schema_url field to contexts #31444
Conversation
… for making schemaURL accessible
…log package in contexts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience. We're headed in the right direction, I left a few comments to help illustrate how I think this should work.
@evan-bradley I think this implementation should now work for ottllog. I have addressed your comments in the latest commits. Requesting your review on this. However, I still have one question. how would we change the |
@evan-bradley Lets get this PR merged this week. I think we are very close to what we need. Please give your review for the latest commit. Thanks |
@evan-bradley @TylerHelmuth can we merge this PR now ? |
@kernelpanic77 Could you fix the lint issues? |
running |
Ready to merge 👍 |
@kernelpanic77 looks like the linter is still failing. You can run |
@TylerHelmuth the linter is expected to fail here, since the SchemaURLItem interface uses the same signature to get and set a schema_url string.
For instance |
This PR attempts to make schemaURL for TransformContexts.
Description:
Added a breaking change to creation of TransformContext function for logs. Also made changes to all references of the function.
Link to tracking Issue:
#30229