fix: enabling gzip was causing eof errors upon decompression #32081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leorinat
requested review from
Aneurysm9,
MovieStoreGuy and
a team
as code owners
MovieStoreGuy
approved these changes
Apr 2, 2024
|
Fixes #30108 |
|
Hey @leorinat , You'll need to add a changelog entry for this PR to be merged, I believe it should be |
Done, thanks. |
exporter/awskinesisexporter/internal/compress/noop_compression.go
Outdated
Show resolved
Hide resolved
MovieStoreGuy
added
the
ready to merge
|
Its not exactly clear to me why the correctness tests are failing, let check if it is also impacting main. |
jamesmoessis
approved these changes
Apr 2, 2024
ycombinator
pushed a commit
to ycombinator/opentelemetry-collector-contrib
that referenced
this pull request
Apr 9, 2024
…lemetry#32081) **Description:** Fixed issue when enabling compression: gzip **Testing:** Locally decompressed the generated payloads before and after the fix --------- Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
This PR doesn't address the parallel compression bug you referenced here. I've added some more comments on the issue: |
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…lemetry#32081) **Description:** Fixed issue when enabling compression: gzip **Testing:** Locally decompressed the generated payloads before and after the fix --------- Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed issue when enabling compression: gzip
Testing:
Locally decompressed the generated payloads before and after the fix