Jaeger translation of span status to pdata incorrectly parsed as integer

[MrAlias]

Description

The jaegerthrift receiver parses the otel.status_code tag as an integer.

opentelemetry-collector-contrib/pkg/translator/jaeger/jaegerproto_to_traces.go

Line 261 in 3de607f

i, err := strconv.Atoi(attrVal.StringVal())

The OpenTelemetry specification specifies this tag to be a string of OK or ERROR values.

Currently, this is correctly marking spans as errors because the jaeger span also has the error tag set to indicate the error and a span an appropriately tagged otel.span_status field will fail to parse and not override this status code. However, if, like in the Go implementation, the tag is infact an integer and the integer does not match the pdata definitions of status, it is possible for an error spans to be marked successful.

Proposal

• Parse OK and ERROR strings and translate to appropriate pdata status.
• Fallback to parsing otel.status_code only when the error tag is not set. Otherwise there is a chance the first parse of error is overwritten.

[MrAlias]

I'm working on a resolution for this.