Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate link checker, after upgrade tests are passing #5118

Closed
bogdandrutu opened this issue Mar 30, 2022 · 3 comments · Fixed by #5186
Closed

Investigate link checker, after upgrade tests are passing #5118

bogdandrutu opened this issue Mar 30, 2022 · 3 comments · Fixed by #5186
Labels
bug Something isn't working good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up priority:p3 Lowest

Comments

@bogdandrutu
Copy link
Member

Since we upgraded to latest gaurav-nelson/github-action-markdown-link-check@1.0.14 (from 1.0.13) every time we change something in a md file with links we fail the link check, see:
https://github.com/open-telemetry/opentelemetry-collector/runs/5755269731?check_suite_focus=true

Something that may be related open-telemetry/opentelemetry-specification#2426.

@bogdandrutu bogdandrutu added bug Something isn't working help wanted Good issue for contributors to OpenTelemetry Service to pick up good first issue Good for newcomers labels Mar 30, 2022
@petertamuk
Copy link

Hello, I'm new to contributing and would like to look in to this issue if that's alright.

Taking a look over at github-action-markdown-link-check it appears the owner has move v1.0.14 to a per-release version and labelled v1.0.13 as the latest. Issue: 127

I believe the actions for this issue would simply involve updating check-lints.yaml L19 to v1.0.13. Does that sound correct?

@bogdandrutu
Copy link
Member Author

Indeed seem to be lots of errors... But our errors seem to be for internal references, which I am confident should work. All dead links are internal:

FILE: docs/release.md
  [✖] #releasing-opentelemetry-collector → Status: [40](https://github.com/open-telemetry/opentelemetry-collector/runs/5755269731?check_suite_focus=true#step:4:40)4
  [✖] #releasing-opentelemetry-collector-contrib → Status: 404
  [✖] #producing-the-artifacts → Status: 404
  [✖] #release-schedule → Status: 404

  16 links checked.

  ERROR: 4 dead links found!
  [✖] #releasing-opentelemetry-collector → Status: 404
  [✖] #releasing-opentelemetry-collector-contrib → Status: 404
  [✖] #producing-the-artifacts → Status: 404
  [✖] #release-schedule → Status: 404

@bogdandrutu bogdandrutu added the priority:p3 Lowest label Apr 8, 2022
@TylerHelmuth
Copy link
Member

I think that @petertamuk is right that the issue is with v1.0.14. I think until github-action-markdown-link-check is updated to use markdown-lint-check v3.10.0 we should revert back to v1.0.13, which is what the maintainers of the action recommend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up priority:p3 Lowest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants