Fix bug where MutatesData would not correctly propogate through connectors #9053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
connectors-propogate-mutates-data
branch
from
a735d8b
to
3ad326f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9053 +/- ##
=======================================
Coverage 91.57% 91.57%
=======================================
Files 316 316
Lines 17147 17161 +14
=======================================
+ Hits 15702 15716 +14
Misses 1150 1150
Partials 295 295 ☔ View full report in Codecov by Sentry. |
bogdandrutu
reviewed
Dec 7, 2023
djaglowski
force-pushed
the
connectors-propogate-mutates-data
branch
from
3ad326f
to
41274a2
Compare
djaglowski
force-pushed
the
connectors-propogate-mutates-data
branch
from
41274a2
to
6a03bda
Compare
dmitryax
reviewed
Dec 8, 2023
| @@ -42,7 +42,7 @@ type metricsConsumer struct { | |||
| } | |||
|
|
|||
| func (msc *metricsConsumer) Capabilities() consumer.Capabilities { | |||
| return consumer.Capabilities{MutatesData: false} | |||
| return consumer.Capabilities{MutatesData: len(msc.mutable) > 0} | |||
There was a problem hiding this comment.
If there is a readonly receiver in the fan-out, it's not mutating. The mutable data will be copied
Suggested change
| return consumer.Capabilities{MutatesData: len(msc.mutable) > 0} | |
| return consumer.Capabilities{MutatesData: len(msc.mutable) > 0 && len(msc. readonly) == 0} |
bogdandrutu
approved these changes
Dec 9, 2023
dmitryax
pushed a commit
that referenced
this pull request
Dec 11, 2023
Follow up to #9053. @dmitryax pointed out [here](#9053 (comment)) that the fanout consumer will pass original data to a non-mutating consumer if any is available. This PR incorporates that point and updates test expectations accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two closely related problems.