Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support identical instrument registration and handle conflicts #2925

Closed
alanwest opened this issue Feb 22, 2022 · 0 comments · Fixed by #2916
Closed

Support identical instrument registration and handle conflicts #2925

alanwest opened this issue Feb 22, 2022 · 0 comments · Fixed by #2916
Labels
enhancement New feature or request
Milestone

Comments

@alanwest
Copy link
Member

alanwest commented Feb 22, 2022

We currently reject instruments with duplicate names - that is, we log out a warning.

if (this.metricStreamNames.Contains(metricStreamName))
{
OpenTelemetrySdkEventSource.Log.MetricInstrumentIgnored(metricName, instrument.Meter.Name, "Metric name conflicting with existing name.", "Either change the name of the instrument or change name using View.");
return null;
}

Identical instrument registrations (name, kind, unit, description, and data type - int, double, etc) need to be allowed.

When instruments are not identical but are duplicated by name a warning should still be produced. Though, a new metric stream should be created.

Related spec change

Relevant sections of the spec:

@alanwest alanwest added the enhancement New feature or request label Feb 22, 2022
@alanwest alanwest added this to the 1.2.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant