diff --git a/exporters/otlp/otlpmetric/otlpmetricgrpc/client_test.go b/exporters/otlp/otlpmetric/otlpmetricgrpc/client_test.go index 541723ebe2d..68db12f1e4f 100644 --- a/exporters/otlp/otlpmetric/otlpmetricgrpc/client_test.go +++ b/exporters/otlp/otlpmetric/otlpmetricgrpc/client_test.go @@ -168,6 +168,8 @@ func TestNewExporter_invokeStartThenStopManyTimes(t *testing.T) { } func TestNewExporter_collectorConnectionDiesThenReconnectsWhenInRestMode(t *testing.T) { + // TODO: Fix this test #1527 + t.Skip("This test is flaky and needs to be rewritten") mc := runMockCollector(t) reconnectionPeriod := 20 * time.Millisecond @@ -491,6 +493,8 @@ func newThrottlingError(code codes.Code, duration time.Duration) error { } func TestNewExporter_collectorConnectionDiesThenReconnects(t *testing.T) { + // TODO: Fix this test #1527 + t.Skip("This test is flaky and needs to be rewritten") mc := runMockCollector(t) reconnectionPeriod := 50 * time.Millisecond diff --git a/exporters/otlp/otlptrace/otlptracegrpc/client_test.go b/exporters/otlp/otlptrace/otlptracegrpc/client_test.go index c9ebdf40683..1694d219a21 100644 --- a/exporters/otlp/otlptrace/otlptracegrpc/client_test.go +++ b/exporters/otlp/otlptrace/otlptracegrpc/client_test.go @@ -164,6 +164,8 @@ func TestNew_invokeStartThenStopManyTimes(t *testing.T) { } func TestNew_collectorConnectionDiesThenReconnectsWhenInRestMode(t *testing.T) { + // TODO: Fix this test #1527 + t.Skip("This test is flaky and needs to be rewritten") mc := runMockCollector(t) reconnectionPeriod := 20 * time.Millisecond @@ -221,6 +223,8 @@ func TestNew_collectorConnectionDiesThenReconnectsWhenInRestMode(t *testing.T) { } func TestNew_collectorConnectionDiesThenReconnects(t *testing.T) { + // TODO: Fix this test #1527 + t.Skip("This test is flaky and needs to be rewritten") mc := runMockCollector(t) reconnectionPeriod := 50 * time.Millisecond diff --git a/metric/sdkapi/noop.go b/metric/sdkapi/noop.go index c5bf5452f02..90450d3968d 100644 --- a/metric/sdkapi/noop.go +++ b/metric/sdkapi/noop.go @@ -36,7 +36,7 @@ func NewNoopSyncInstrument() SyncImpl { return noopSyncInstrument{} } -// NewNoopSyncInstrument returns a No-op implementation of the +// NewNoopAsyncInstrument returns a No-op implementation of the // asynchronous instrument interface. func NewNoopAsyncInstrument() SyncImpl { return noopSyncInstrument{}