From 338edfc4461c5fc741a76a27126e6b74297488b7 Mon Sep 17 00:00:00 2001 From: dmathieu Date: Mon, 8 Apr 2024 09:49:12 +0200 Subject: [PATCH] indicate invalid slice if we couldn't turn them into json --- attribute/value.go | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/attribute/value.go b/attribute/value.go index 027177b2e62..9ea0ecbbd27 100644 --- a/attribute/value.go +++ b/attribute/value.go @@ -231,17 +231,26 @@ func (v Value) Emit() string { case BOOL: return strconv.FormatBool(v.AsBool()) case INT64SLICE: - j, _ := json.Marshal(v.asInt64Slice()) + j, err := json.Marshal(v.asInt64Slice()) + if err != nil { + return fmt.Sprintf("invalid: %v", v.asInt64Slice()) + } return string(j) case INT64: return strconv.FormatInt(v.AsInt64(), 10) case FLOAT64SLICE: - j, _ := json.Marshal(v.asFloat64Slice()) + j, err := json.Marshal(v.asFloat64Slice()) + if err != nil { + return fmt.Sprintf("invalid: %v", v.asFloat64Slice()) + } return string(j) case FLOAT64: return fmt.Sprint(v.AsFloat64()) case STRINGSLICE: - j, _ := json.Marshal(v.asStringSlice()) + j, err := json.Marshal(v.asStringSlice()) + if err != nil { + return fmt.Sprintf("invalid: %v", v.asStringSlice()) + } return string(j) case STRING: return v.stringly