diff --git a/semconv/v1.4.0/http_test.go b/semconv/v1.4.0/http_test.go index 828f9ea6951..e343350862c 100644 --- a/semconv/v1.4.0/http_test.go +++ b/semconv/v1.4.0/http_test.go @@ -867,10 +867,8 @@ func TestSpanStatusFromHTTPStatusCode(t *testing.T) { assert.Empty(t, msg, "message should not be set if error can be inferred from code") } } - code, valid := validateHTTPStatusCode(400) - if !valid { - assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code") - } + code, _ := SpanStatusFromHTTPStatusCode(400, trace.SpanKindServer) + assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code") } func getExpectedCodeForHTTPCode(code int, spanKind trace.SpanKind) codes.Code { diff --git a/semconv/v1.5.0/http_test.go b/semconv/v1.5.0/http_test.go index 1abafb2ba30..209424f3fbc 100644 --- a/semconv/v1.5.0/http_test.go +++ b/semconv/v1.5.0/http_test.go @@ -867,10 +867,8 @@ func TestSpanStatusFromHTTPStatusCode(t *testing.T) { assert.Empty(t, msg, "message should not be set if error can be inferred from code") } } - code, valid := validateHTTPStatusCode(400) - if !valid { - assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code") - } + code, _ := SpanStatusFromHTTPStatusCode(400, trace.SpanKindServer) + assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code") } func getExpectedCodeForHTTPCode(code int, spanKind trace.SpanKind) codes.Code { diff --git a/semconv/v1.6.1/http_test.go b/semconv/v1.6.1/http_test.go index 258aba685e3..466711697d8 100644 --- a/semconv/v1.6.1/http_test.go +++ b/semconv/v1.6.1/http_test.go @@ -866,10 +866,8 @@ func TestSpanStatusFromHTTPStatusCode(t *testing.T) { assert.Empty(t, msg, "message should not be set if error can be inferred from code") } } - code, valid := validateHTTPStatusCode(400) - if !valid { - assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code") - } + code, _ := SpanStatusFromHTTPStatusCode(400, trace.SpanKindServer) + assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code") } func getExpectedCodeForHTTPCode(code int, spanKind trace.SpanKind) codes.Code { diff --git a/semconv/v1.7.0/http_test.go b/semconv/v1.7.0/http_test.go index 003cb509975..2e97aec7db4 100644 --- a/semconv/v1.7.0/http_test.go +++ b/semconv/v1.7.0/http_test.go @@ -867,10 +867,9 @@ func TestSpanStatusFromHTTPStatusCode(t *testing.T) { assert.Empty(t, msg, "message should not be set if error can be inferred from code") } } - code, valid := validateHTTPStatusCode(400) - if !valid { - assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code") - } + code, _ := SpanStatusFromHTTPStatusCode(400, trace.SpanKindServer) + assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code") + } func getExpectedCodeForHTTPCode(code int, spanKind trace.SpanKind) codes.Code {