You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For example, MeterImpl sounds like a concrete type for Meter even though it's not. In Go, *Impl is not a naming convention for concrete types either. So the API surface looks unidiomatic and harder to navigate from the users perspective.
The text was updated successfully, but these errors were encountered:
rakyll
changed the title
*Impl type names are confusing to Go developers
*Impl type names are confusing
Oct 28, 2020
Per spec, https://github.com/open-telemetry/opentelemetry-specification/tree/master/specification/metrics, there are various metrics interfaces that sit in the boundary of the SDK and the API. These types are named as "*Impl" which resembles "implementation" types from other languages. Is there a better way to rename them to avoid the confusion that they are concrete types.
For example, MeterImpl sounds like a concrete type for Meter even though it's not. In Go, *Impl is not a naming convention for concrete types either. So the API surface looks unidiomatic and harder to navigate from the users perspective.
The text was updated successfully, but these errors were encountered: