Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async/Sync concepts shouldn't be represented as types #1289

Closed
rakyll opened this issue Oct 29, 2020 · 2 comments
Closed

Async/Sync concepts shouldn't be represented as types #1289

rakyll opened this issue Oct 29, 2020 · 2 comments
Labels
area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package
Projects

Comments

@rakyll
Copy link
Contributor

rakyll commented Oct 29, 2020

The metrics specs introduces async and sync as concepts to explain how the data collection will be behave, https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/metrics/api.md#synchronous-and-asynchronous-instruments-compared.

These concepts doesn't necessarily have to be represented in the API but rather their behavior should be expressed in observer vs non-observer aggregators (as it's already done, e.g. Observers implement Async, non-observers implement Sync methods). Exposing these concepts as types make it extreme difficult for the user to understand what they are for.

(I'm currently working on an experimental package that restructures the metric package that will address this issue. I will share it once I'm feeling better about it but filing this issue as a placeholder so we can have a conversation about it.)

@MrAlias
Copy link
Contributor

MrAlias commented Oct 29, 2020

I'm currently working on an experimental package that restructures the metric package that will address this issue. I will share it once I'm feeling better about it but filing this issue as a placeholder so we can have a conversation about it.

I'm excited to see this!

@MrAlias MrAlias added area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package priority:p1 labels Oct 29, 2020
@MrAlias MrAlias added this to To do in P1 Burndown via automation Oct 29, 2020
@MrAlias MrAlias added this to To do in OpenTelemetry Go RC via automation Oct 29, 2020
@MrAlias MrAlias added this to the RC1 milestone Oct 29, 2020
@MrAlias MrAlias removed this from the RC1 milestone Feb 12, 2021
@punya punya removed this from To do in OpenTelemetry Go RC Feb 17, 2021
@MrAlias
Copy link
Contributor

MrAlias commented May 3, 2022

Closing, as this sounds to have been addressed in #2587. Please reopen if this is in error.

@MrAlias MrAlias closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package
Projects
No open projects
P1 Burndown
  
To do
Development

No branches or pull requests

2 participants