Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making aggregators interfaces to support different flavors #1291

Closed
rakyll opened this issue Oct 29, 2020 · 3 comments
Closed

Making aggregators interfaces to support different flavors #1291

rakyll opened this issue Oct 29, 2020 · 3 comments
Labels
area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package
Projects

Comments

@rakyll
Copy link
Contributor

rakyll commented Oct 29, 2020

In the metric package, we provide different flavors of the aggregator types, such as Float64SumObserver
vs BoundFloat64UpDownCounter. This is adding some mental overhead for the developer and requiring them to see another type. Instead of exporting various concrete types, would it be better to turn Float64SumObserver into an interface and provide two unexported concrete types?

@rakyll
Copy link
Contributor Author

rakyll commented Oct 29, 2020

Or following this model at #1292, we split the bound types into separate packages, so they don't confuse the users.

@MrAlias MrAlias added area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package priority:p1 labels Oct 29, 2020
@MrAlias MrAlias added this to To do in P1 Burndown via automation Oct 29, 2020
@MrAlias MrAlias added this to To do in OpenTelemetry Go RC via automation Oct 29, 2020
@MrAlias MrAlias added this to the RC1 milestone Oct 29, 2020
@jmacd
Copy link
Contributor

jmacd commented Dec 11, 2020

Either approach sounds good.

@MrAlias MrAlias removed this from the RC1 milestone Feb 12, 2021
@punya punya removed this from To do in OpenTelemetry Go RC Feb 17, 2021
@MrAlias
Copy link
Contributor

MrAlias commented May 3, 2022

This issues looks to have been resolved by #2587

@MrAlias MrAlias closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package
Projects
No open projects
P1 Burndown
  
To do
Development

No branches or pull requests

3 participants