Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated oteltest package #2234

Merged
merged 2 commits into from Sep 9, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 9, 2021

Resolve #2230

OpenTelemetry Go 1.0.0 automation moved this from In progress to Reviewer approved Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #2234 (5e80b41) into main (486afd3) will decrease coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2234     +/-   ##
=======================================
- Coverage   72.7%   72.3%   -0.5%     
=======================================
  Files        175     168      -7     
  Lines      12182   11832    -350     
=======================================
- Hits        8863    8561    -302     
+ Misses      3076    3034     -42     
+ Partials     243     237      -6     
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 93.4% <0.0%> (-0.9%) ⬇️

@Aneurysm9 Aneurysm9 merged commit 9e7812d into open-telemetry:main Sep 9, 2021
OpenTelemetry Go 1.0.0 automation moved this from Reviewer approved to Done Sep 9, 2021
@MrAlias MrAlias mentioned this pull request Sep 20, 2021
@gigglegrig
Copy link

Hi, just realized that the oteltest is removed in the latest versions.

We had tests like oteltest.NewTracerProvider(oteltest.WithSpanRecorder) and oteltest.SpanRecorder in our code before, what's the recommended substitution after the removal?

@MrAlias MrAlias deleted the rm-oteltest branch January 12, 2022 21:21
@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 12, 2022

@gigglegrig Please take a look at the sdk/trace/tracetest package, specifically "go.opentelemetry.io/otel/skd/trace/tracetest".SpanRecorder which can be registered with the default SDK TracerProvider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Remove the deprecated oteltest package
5 participants